Async KV Store #3778
Draft
Async KV Store #3778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! I see this is a draft PR. |
joostjager
force-pushed
the
async-kv-store
branch
from
391ffb1 to
faa071d
Compare
joostjager
commented
May 15, 2025
lightning/src/util/async_persist.rs
Outdated
| Poll::Pending => { | ||
| println!("Future not ready, using tokio runtime"); | ||
|
|
||
| self.runtime.spawn(async move { |
There was a problem hiding this comment.
This doesn't need to be tokio, it could be a generic spawn method too of course.
joostjager
commented
May 15, 2025
lightning/src/util/async_persist.rs
Outdated
|
|
||
| match fut.as_mut().poll(&mut cx) { | ||
| Poll::Ready(_) => { | ||
| UpdateStatus::Completed |
There was a problem hiding this comment.
This initiates the stable persistence flow in LDK.
joostjager
force-pushed
the
async-kv-store
branch
2 times, most recently
from
d57cf75 to
4678f85
Compare
This was referenced Jun 2, 2025
joostjager
commented
Jun 3, 2025
lightning/src/util/persist.rs
Outdated
| @@ -134,9 +136,9 @@ pub trait KVStore { | |||
| /// | |||
| /// Will create the given `primary_namespace` and `secondary_namespace` if not already present | |||
| /// in the store. | |||
| fn write( | |||
| fn write_async( | |||
There was a problem hiding this comment.
Reminder: document that these calls, even though they are async, need to complete in the order in which they are initiated.
joostjager
force-pushed
the
async-kv-store
branch
from
217d757 to
e551842
Compare
joostjager
commented
Jun 10, 2025
| let mut cx = Context::from_waker(&waker); | ||
|
|
||
| match fut.as_mut().poll(&mut cx) { | ||
| Poll::Ready(Ok(())) => Ok(true), |
There was a problem hiding this comment.
Reminder - can't simply conclude here that we are in sync mode. An async implementation may also sometimes be ready immediately?
Prepare for adding runtime state while avoiding the _unused serialization macro config.
To prepare for an async kv store trait that must be awaited, this commit moves the kv store calls from the chain notification handlers to the background process. It uses a dirty flag to communicate that there is something to persist. The block height is part of the persisted data. If that data does not make it to disk, the chain notifications are replayed after restart.
joostjager
force-pushed
the
async-kv-store
branch
from
3d49db7 to
d31760d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for discussion on approach
Relates to #1470